Skip to content

Cosmos DB - POST operation for retrieving read only keys#3233

Merged
anuchandy merged 2 commits intoAzure:masterfrom
dmakwana:postReadOnlyKeys
Jun 19, 2018
Merged

Cosmos DB - POST operation for retrieving read only keys#3233
anuchandy merged 2 commits intoAzure:masterfrom
dmakwana:postReadOnlyKeys

Conversation

@dmakwana
Copy link
Contributor

@dmakwana dmakwana commented Jun 14, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@azuresdkci azuresdkci requested a review from anuchandy June 14, 2018 00:23
@AutorestCI AutorestCI mentioned this pull request Jun 14, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2781

@AutorestCI AutorestCI mentioned this pull request Jun 14, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2728

@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2071

@AutorestCI AutorestCI mentioned this pull request Jun 14, 2018
Merged
anuchandy
anuchandy reviewed Jun 14, 2018
View reviewed changes
specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2015-04-08/cosmos-db.json
"200": {
"description": "The operation completed successfully.",
"schema": {
"$ref": "#/definitions/DatabaseAccountListReadOnlyKeysResult"
Copy link
Member

@anuchandy anuchandy Jun 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems both DatabaseAccounts_GetReadOnlyKeys and DatabaseAccounts_ListReadOnlyKeys returns the same result. Are we planning to deprecate one of this eventually?

Copy link
Contributor Author

@dmakwana dmakwana Jun 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the GET is to be deprecated

Copy link
Member

@anuchandy anuchandy Jun 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. Is this new POST action to retrieve the keys a long running operation?

Copy link
Contributor Author

@dmakwana dmakwana Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

Copy link
Member

@anuchandy anuchandy Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmakwana any reason why we use POST for listing keys?

Adding Gaurav - @ravbhatnagar any concern here from ARM side? the context is:

  1. There is already an operation to retrieve the database keys which is based on HTTP GET
  2. We are introducing a new operation for retrieving the same database keys which is based on HTTP POST (this is not a long running operation)
  3. The operation based on GET will be deprecated.

Copy link
Contributor

@ravbhatnagar ravbhatnagar Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuchandy - Yes, this is the right way. secrets like keys should not be exposed via a GET. Right way is through a POST. Thanks for checking!

Copy link
Member

@anuchandy anuchandy Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ravbhatnagar.

@dmakwana merging the PR.

@anuchandy anuchandy merged commit 07ba046 into Azure:master Jun 19, 2018
@AutorestCI AutorestCI mentioned this pull request Jun 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy approved these changes

+2 more reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@sujitvk1 sujitvk1 sujitvk1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anuchandy anuchandy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dmakwana @AutorestCI @anuchandy @ravbhatnagar @sujitvk1